From 9baab1aebc29a6eb97f338b800ab5347ee08e145 Mon Sep 17 00:00:00 2001 From: Michael Scire Date: Tue, 20 Feb 2018 13:51:17 -0800 Subject: [PATCH] Clarify PASLR commentary --- exosphere/userpage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exosphere/userpage.c b/exosphere/userpage.c index 5099a8a0a..6e0bf2801 100644 --- a/exosphere/userpage.c +++ b/exosphere/userpage.c @@ -12,13 +12,13 @@ int upage_init(upage_ref_t *upage, void *user_address) { upage->secure_page = 0ULL; if (g_secure_page_user_address != NULL) { - /* Different ASLR'd address indicate SPL was rebooted. Panic. */ + /* Different physical address indicate SPL was rebooted, or another process got access to svcCallSecureMonitor. Panic. */ if (g_secure_page_user_address != upage->user_page) { panic(); } upage->secure_page = SECURE_USER_PAGE_ADDR; } else { - /* Official (weak) validation for SPL's ASLR'd address. */ + /* Weakly validate SPL's physically random address is in DRAM. */ if (upage->user_page >> 31) { g_secure_page_user_address = upage->user_page; /* TODO: Map this page into the MMU and invalidate the TLB. */