kern: minor cleanup (thanks @liamwhite)

This commit is contained in:
Michael Scire 2023-03-06 21:18:00 -07:00
parent e2ebf9c0ff
commit 8da4d14e15
3 changed files with 3 additions and 4 deletions

View file

@ -48,7 +48,7 @@ namespace ams::kern {
/* Check that the object is closed. */
R_UNLESS(derived->IsServerClosed(), svc::ResultInvalidState());
return Delete(obj.GetPointerUnsafe(), name);
R_RETURN(Delete(obj.GetPointerUnsafe(), name));
}
template<typename Derived> requires std::derived_from<Derived, KAutoObject>

View file

@ -234,11 +234,11 @@ namespace ams::kern {
KPriorityQueueImpl m_scheduled_queue;
KPriorityQueueImpl m_suggested_queue;
private:
constexpr ALWAYS_INLINE void ClearAffinityBit(u64 &affinity, s32 core) {
static constexpr ALWAYS_INLINE void ClearAffinityBit(u64 &affinity, s32 core) {
affinity &= ~(UINT64_C(1) << core);
}
constexpr ALWAYS_INLINE s32 GetNextCore(u64 &affinity) {
static constexpr ALWAYS_INLINE s32 GetNextCore(u64 &affinity) {
const s32 core = __builtin_ctzll(static_cast<unsigned long long>(affinity));
ClearAffinityBit(affinity, core);
return core;

View file

@ -29,7 +29,6 @@ _ZN3ams4kern10KScheduler12ScheduleImplEv:
mov x1, x0
/* First, clear the need's scheduling bool (and dmb ish after, as it's an atomic). */
/* TODO: Should this be a stlrb? Nintendo does not do one. */
strb wzr, [x1]
dmb ish