thermosphere: C++ vgic

This commit is contained in:
TuxSH 2020-02-15 02:05:54 +00:00
parent 31e5ff7c1d
commit 1ee289f5f1
4 changed files with 297 additions and 16 deletions

View file

@ -91,7 +91,6 @@ namespace ams::hvisor {
m_numPriorityLevels = static_cast<u8>(BIT(__builtin_popcount(gicd->ipriorityr[0]))); m_numPriorityLevels = static_cast<u8>(BIT(__builtin_popcount(gicd->ipriorityr[0])));
m_numCpuInterfaces = static_cast<u8>(1 + ((gicd->typer >> 5) & 7)); m_numCpuInterfaces = static_cast<u8>(1 + ((gicd->typer >> 5) & 7));
m_numListRegisters = static_cast<u8>(1 + (gich->vtr & 0x3F));
} }
// Only one core will reset the GIC state for the shared peripheral interrupts // Only one core will reset the GIC state for the shared peripheral interrupts
@ -149,7 +148,7 @@ namespace ams::hvisor {
ClearInterruptEnabled(id); ClearInterruptEnabled(id);
ClearInterruptPending(id); ClearInterruptPending(id);
if (id >= 32) { if (id >= 32) {
SetInterruptMode(id, isLevelSensitive); SetInterruptMode(id, !isLevelSensitive);
SetInterruptTargets(id, 0xFF); // all possible processors SetInterruptTargets(id, 0xFF); // all possible processors
} }
SetInterruptPriority(id, prio); SetInterruptPriority(id, prio);

View file

@ -45,15 +45,15 @@ namespace ams::hvisor {
static void ClearInterruptActive(u32 id) { gicd->icactiver[id / 32] = BIT(id % 32); } static void ClearInterruptActive(u32 id) { gicd->icactiver[id / 32] = BIT(id % 32); }
static void SetInterruptShiftedPriority(u32 id, u8 prio) { gicd->ipriorityr[id] = prio; } static void SetInterruptShiftedPriority(u32 id, u8 prio) { gicd->ipriorityr[id] = prio; }
static void SetInterruptTargets(u32 id, u8 targetList) { gicd->itargetsr[id] = targetList; } static void SetInterruptTargets(u32 id, u8 targetList) { gicd->itargetsr[id] = targetList; }
static bool IsInterruptLevelSensitive(u32 id) static bool IsInterruptEdgeTriggered(u32 id)
{ {
return ((gicd->icfgr[id / 16] >> GicV2Distributor::GetCfgrShift(id)) & 2) != 0; return ((gicd->icfgr[id / 16] >> GicV2Distributor::GetCfgrShift(id)) & 2) != 0;
} }
static void SetInterruptMode(u32 id, bool isLevelSensitive) static void SetInterruptMode(u32 id, bool isEdgeTriggered)
{ {
u32 cfgw = gicd->icfgr[id / 16]; u32 cfgw = gicd->icfgr[id / 16];
cfgw &= ~(2 << GicV2Distributor::GetCfgrShift(id)); cfgw &= ~(2 << GicV2Distributor::GetCfgrShift(id));
cfgw |= (!isLevelSensitive ? 2 : 0) << GicV2Distributor::GetCfgrShift(id); cfgw |= (isEdgeTriggered ? 2 : 0) << GicV2Distributor::GetCfgrShift(id);
gicd->icfgr[id / 16] = cfgw; gicd->icfgr[id / 16] = cfgw;
} }
@ -67,7 +67,6 @@ namespace ams::hvisor {
u8 m_priorityShift = 0; u8 m_priorityShift = 0;
u8 m_numPriorityLevels = 0; u8 m_numPriorityLevels = 0;
u8 m_numCpuInterfaces = 0; u8 m_numCpuInterfaces = 0;
u8 m_numListRegisters = 0;
private: private:
void SetInterruptPriority(u32 id, u8 prio) { SetInterruptShiftedPriority(id, prio << m_priorityShift); } void SetInterruptPriority(u32 id, u8 prio) { SetInterruptShiftedPriority(id, prio << m_priorityShift); }

View file

@ -16,6 +16,7 @@
#include <mutex> #include <mutex>
#include "hvisor_virtual_gic.hpp" #include "hvisor_virtual_gic.hpp"
#include "cpu/hvisor_cpu_instructions.hpp"
#define GICDOFF(field) (offsetof(GicV2Distributor, field)) #define GICDOFF(field) (offsetof(GicV2Distributor, field))
@ -178,11 +179,11 @@ namespace ams::hvisor {
VirqState &state = GetVirqState(id); VirqState &state = GetVirqState(id);
// Expose bit(2n) as nonprogrammable to the guest no matter what the physical distributor actually behaves // Expose bit(2n) as nonprogrammable to the guest no matter what the physical distributor actually behaves
bool newLvl = ((config & 2) << GicV2Distributor::GetCfgrShift(id)) == 0; bool newEdgeTriggered = ((config & 2) << GicV2Distributor::GetCfgrShift(id)) != 0;
if (state.levelSensitive != newLvl) { if (state.edgeTriggered != newEdgeTriggered) {
state.levelSensitive = newLvl; state.edgeTriggered = newEdgeTriggered;
IrqManager::SetInterruptMode(id, newLvl); IrqManager::SetInterruptMode(id, newEdgeTriggered);
} }
} }
@ -427,7 +428,7 @@ namespace ams::hvisor {
we're notified when they become pending again. we're notified when they become pending again.
*/ */
if (!state.levelSensitive || !state.IsPending()) { if (state.edgeTriggered || !state.IsPending()) {
// Nothing to do for edge-triggered interrupts and non-pending interrupts // Nothing to do for edge-triggered interrupts and non-pending interrupts
return; return;
} }
@ -479,7 +480,252 @@ namespace ams::hvisor {
for (size_t i = 0; i < numChosen; i++) { for (size_t i = 0; i < numChosen; i++) {
chosen[i]->handled = true; chosen[i]->handled = true;
chosen[i]->coreId = currentCoreCtx->coreId;
m_virqPendingQueue.erase(*chosen[i]); m_virqPendingQueue.erase(*chosen[i]);
} }
} }
void VirtualGic::PushListRegisters(VirqState *chosen[], size_t num)
{
for (size_t i = 0; i < num; i++) {
VirqState &state = *chosen[i];
u32 irqId = state.irqId;
GicV2VirtualInterfaceController::ListRegister lr = {0};
lr.grp1 = false; // group0
lr.priority = state.priority;
lr.virtualId = irqId;
// We only add new pending interrupts here...
lr.pending = true;
lr.active = false;
// We don't support guests setting the pending latch, so the logic is probably simpler...
if (irqId < 16) {
// SGI
lr.physicalId = BIT(9) /* EOI notification bit */ | state.srcCoreId;
// ^ IDK how kvm gets away with not setting the EOI notif bits in some cases,
// what they do seems to be prone to drop interrupts, etc.
lr.hw = false; // software
} else {
// Actual physical interrupt
lr.hw = true;
lr.physicalId = irqId;
}
volatile auto *freeLr = AllocateListRegister();
ENSURE(freeLr != nullptr);
freeLr->raw = lr.raw;
}
}
bool VirtualGic::UpdateListRegister(volatile GicV2VirtualInterfaceController::ListRegister *lr)
{
GicV2VirtualInterfaceController::ListRegister lrCopy = { .raw = lr->raw };
u32 irqId = lrCopy.virtualId;
// Note: this give priority to multi-SGIs than can be immediately handled
// Update the state
VirqState &state = GetVirqState(irqId);
ENSURE(state.handled);
u32 srcCoreId = state.coreId;
u32 coreId = currentCoreCtx->coreId;
state.active = lrCopy.active;
if (lrCopy.active) {
// We don't dequeue active interrupts
if (irqId < 16) {
// We can allow SGIs to be marked active-pending if it's been made pending from the same source again
// For hw interrupts, the active-pending state is tracked in the real GICD
if (m_incomingSgiPendingSources[coreId][irqId] & BIT(srcCoreId)) {
lrCopy.pending = true;
m_incomingSgiPendingSources[coreId][irqId] &= ~BIT(srcCoreId);
}
}
// If the vIRQ goes from pending to active, it has been acknowledged: clear line level and pending latch
// SGIs are always edge-triggered, so line level doesn't matter & that's why we handle them above to simplify the code
if (!lrCopy.pending) {
state.ClearPendingOnAck();
}
lr->raw = lrCopy.raw;
return true;
} else if (lrCopy.pending) {
// New interrupts might have come, pending status might have been changed, etc.
// We need to put the interrupt back in the pending list (which we clean up afterwards)
state.handled = false;
m_virqPendingQueue.insert(state);
lr->raw = 0;
return false;
} else {
// Interrupt is inactive. This means it has been acked and handled.
// SGIs are always edge-triggered, so line level doesn't matter & that's why we handle them above to simplify the code
if (irqId < 16) {
// Special case for multi-SGIs if they can be immediately handled
if (m_incomingSgiPendingSources[coreId][irqId] != 0) {
srcCoreId = __builtin_ctz(m_incomingSgiPendingSources[coreId][irqId]);
state.srcCoreId = srcCoreId;
m_incomingSgiPendingSources[coreId][irqId] &= ~BIT(srcCoreId);
lrCopy.physicalId = BIT(9) /* EOI notification bit */ | srcCoreId;
lrCopy.pending = true;
lr->raw = lrCopy.raw;
}
}
if (!lrCopy.pending) {
// Inactive interrupt, cleanup
state.ClearPendingOnAck();
state.handled = false;
lr->raw = 0;
return false;
} else {
return true;
}
}
}
void VirtualGic::UpdateState()
{
GicV2VirtualInterfaceController::HypervisorControlRegister hcr = { .raw = gich->hcr.raw };
u32 coreId = currentCoreCtx->coreId;
// First, put back inactive interrupts into the queue, handle some SGI stuff
// Need to handle the LRs in reverse order to keep list stability
u64 usedMap = cpu::rbit(m_usedLrMap[coreId]);
for (auto pos: util::BitsOf{usedMap}) {
if (!UpdateListRegister(&gich->lr[63 - pos])) {
usedMap &= ~BITL(pos);
}
}
m_usedLrMap[coreId] = cpu::rbit(usedMap);
// Then, clean the list up
CleanupPendingQueue();
size_t numFreeLr = GetNumberOfFreeListRegisters();
VirqState *chosen[64];
// Choose interrupts...
size_t numChosen = ChoosePendingInterrupts(chosen, numFreeLr);
// ...and push them
PushListRegisters(chosen, numChosen);
// Enable underflow interrupt when appropriate to do so
hcr.uie = m_numListRegisters - GetNumberOfFreeListRegisters() > 1;
gich->hcr.raw = hcr.raw;
}
void VirtualGic::MaintenanceInterruptHandler()
{
GicV2VirtualInterfaceController::MaintenanceIntStatRegister misr = { .raw = gich->misr.raw };
// Force GICV_CTRL to behave like ns-GICC_CTLR, with group 1 being replaced by group 0
// Ensure we aren't spammed by maintenance interrupts, either.
if (misr.vgrp0e || misr.vgrp0d || misr.vgrp1e || misr.vgrp1d) {
GicV2VirtualInterfaceController::VmControlRegister vmcr = { .raw = gich->vmcr.raw };
vmcr.cbpr = 0;
vmcr.fiqEn = 0;
vmcr.ackCtl = 0;
vmcr.enableGrp1 = 0;
gich->vmcr.raw = vmcr.raw;
}
if (misr.vgrp0e) {
DEBUG("EL2 [core %d]: Group 0 enabled maintenance interrupt\n", (int)currentCoreCtx->coreId);
gich->hcr.vgrp0eie = false;
gich->hcr.vgrp0die = true;
} else if (misr.vgrp0d) {
DEBUG("EL2 [core %d]: Group 0 disabled maintenance interrupt\n", (int)currentCoreCtx->coreId);
gich->hcr.vgrp0eie = true;
gich->hcr.vgrp0die = false;
}
// Already handled the following 2 above:
if (misr.vgrp1e) {
DEBUG("EL2 [core %d]: Group 1 enabled maintenance interrupt\n", (int)currentCoreCtx->coreId);
}
if (misr.vgrp1d) {
DEBUG("EL2 [core %d]: Group 1 disabled maintenance interrupt\n", (int)currentCoreCtx->coreId);
}
if (misr.eoi) {
//DEBUG("EL2 [core %d]: SGI EOI maintenance interrupt\n", currentCoreCtx->coreId);
}
if (misr.u) {
//DEBUG("EL2 [core %d]: Underflow maintenance interrupt\n", currentCoreCtx->coreId);
}
ENSURE2(!misr.lrenp, "List Register Entry Not Present maintenance interrupt!\n");
// The rest should be handled by the main loop...
}
void VirtualGic::EnqueuePhysicalIrq(u32 id)
{
VirqState &state = GetVirqState(id);
state.SetPending();
m_virqPendingQueue.insert(state);
}
void VirtualGic::Initialize()
{
if (currentCoreCtx->isBootCore) {
m_virqPendingQueue.Initialize(m_virqStates.data());
m_numListRegisters = static_cast<u8>(1 + (gich->vtr & 0x3F));
// All fields are reset to 0 on reset and deep sleep exit
for (VirqState &state: m_virqStates) {
state.listPrev = state.listNext = virqListInvalidIndex;
state.priority = lowestPriority;
}
// SPIs (+ reserved interrupts just in case)
for (u32 i = 32; i < 1024; i++) {
GetVirqState(0, i).irqId = i;
}
// SGIs, PPIs
for (u32 coreId = 0; coreId < MAX_CORE; coreId++) {
for (u32 i = 0; i < 32; i++) {
VirqState &state = GetVirqState(coreId, i);
state.coreId = coreId;
state.irqId = i;
if (i < 16) {
state.edgeTriggered = true;
state.enabled = true;
} else {
state.edgeTriggered = IrqManager::IsInterruptEdgeTriggered(i);
}
}
}
// All guest interrupts are initially configured as disabled
// All guest SPIs are initially configured as level-sensitive with no targets
}
// Clear the list registers (they reset to 0, though)
for (u8 i = 0; i < m_numListRegisters; i++) {
gich->lr[i].raw = 0;
}
// Enable a few maintenance interrupts. Enable the virtual interface.
GicV2VirtualInterfaceController::HypervisorControlRegister hcr = {};
hcr.vgrp1eie = true,
hcr.vgrp0eie = true,
hcr.lrenpie = true,
hcr.en = true,
gich->hcr.raw = hcr.raw;
}
} }

View file

@ -34,6 +34,8 @@ namespace ams::hvisor {
// Architectural properties // Architectural properties
static constexpr u32 priorityShift = 3; static constexpr u32 priorityShift = 3;
static constexpr u32 numPriorityLevels = BIT(8 - priorityShift);
static constexpr u32 lowestPriority = numPriorityLevels - 1;
// List managament constants // List managament constants
static constexpr u32 spiEndIndex = GicV2Distributor::maxIrqId + 1 - 32; static constexpr u32 spiEndIndex = GicV2Distributor::maxIrqId + 1 - 32;
@ -51,7 +53,7 @@ namespace ams::hvisor {
bool active : 1; bool active : 1;
bool handled : 1; bool handled : 1;
bool pendingLatch : 1; bool pendingLatch : 1;
bool levelSensitive : 1; bool edgeTriggered : 1;
u32 coreId : 3; u32 coreId : 3;
u32 targetList : 8; u32 targetList : 8;
u32 srcCoreId : 3; u32 srcCoreId : 3;
@ -60,11 +62,11 @@ namespace ams::hvisor {
constexpr bool IsPending() const constexpr bool IsPending() const
{ {
return pendingLatch || (levelSensitive && pending); return pendingLatch || (!edgeTriggered && pending);
} }
constexpr void SetPending() constexpr void SetPending()
{ {
if (levelSensitive) { if (!edgeTriggered) {
pending = true; pending = true;
} else { } else {
pendingLatch = true; pendingLatch = true;
@ -75,7 +77,7 @@ namespace ams::hvisor {
// Don't clear pending latch status // Don't clear pending latch status
pending = false; pending = false;
} }
constexpr bool ClearPending() constexpr bool ClearPendingOnAck()
{ {
// On ack, both pending line status and latch are cleared // On ack, both pending line status and latch are cleared
pending = false; pending = false;
@ -220,6 +222,12 @@ namespace ams::hvisor {
} }
} }
} }
constexpr void Initialize(VirqState *storage)
{
m_storage = storage;
m_first = m_last = &(*end());
}
}; };
@ -237,14 +245,25 @@ namespace ams::hvisor {
IrqManager::GenerateSgiForAllOthers(IrqManager::VgicUpdateSgi); IrqManager::GenerateSgiForAllOthers(IrqManager::VgicUpdateSgi);
} }
static u64 GetEmptyListStatusRegister()
{
return static_cast<u64>(gich->elsr1) << 32 | static_cast<u64>(gich->elsr0);
}
static u64 GetNumberOfFreeListRegisters()
{
return __builtin_popcountll(GetEmptyListStatusRegister());
}
private: private:
std::array<VirqState, maxNumIntStates> m_virqStates{}; std::array<VirqState, maxNumIntStates> m_virqStates{};
std::array<std::array<u8, 32>, MAX_CORE> m_incomingSgiPendingSources{}; std::array<std::array<u8, 32>, MAX_CORE> m_incomingSgiPendingSources{};
std::array<u64, MAX_CORE> m_usedLrMap{};
VirqQueue m_virqPendingQueue{}; VirqQueue m_virqPendingQueue{};
bool m_distributorEnabled = false; bool m_distributorEnabled = false;
u8 m_numListRegisters = 0;
private: private:
constexpr VirqState &GetVirqState(u32 coreId, u32 id) constexpr VirqState &GetVirqState(u32 coreId, u32 id)
{ {
@ -313,7 +332,7 @@ namespace ams::hvisor {
u32 GetInterruptConfigBits(u16 id) u32 GetInterruptConfigBits(u16 id)
{ {
u32 oneNModel = id < 32 || !IrqManager::IsGuestInterrupt(id) ? 0 : 1; u32 oneNModel = id < 32 || !IrqManager::IsGuestInterrupt(id) ? 0 : 1;
return (IrqManager::IsGuestInterrupt(id) && !GetVirqState(id).levelSensitive) ? 2 | oneNModel : oneNModel; return (IrqManager::IsGuestInterrupt(id) && GetVirqState(id).edgeTriggered) ? 2 | oneNModel : oneNModel;
} }
u32 GetPeripheralId2Register(void) u32 GetPeripheralId2Register(void)
@ -333,6 +352,20 @@ namespace ams::hvisor {
void CleanupPendingQueue(); void CleanupPendingQueue();
size_t ChoosePendingInterrupts(VirqState *chosen[], size_t maxNum); size_t ChoosePendingInterrupts(VirqState *chosen[], size_t maxNum);
volatile GicV2VirtualInterfaceController::ListRegister *AllocateListRegister(void)
{
u32 ff = __builtin_ffsll(GetEmptyListStatusRegister());
if (ff == 0) {
return nullptr;
} else {
m_usedLrMap[currentCoreCtx->coreId] |= BITL(ff - 1);
return &gich->lr[ff - 1];
}
}
void PushListRegisters(VirqState *chosen[], size_t num);
bool UpdateListRegister(volatile GicV2VirtualInterfaceController::ListRegister *lr);
void UpdateState(); void UpdateState();
public: public:
@ -341,6 +374,10 @@ namespace ams::hvisor {
void WriteGicdRegister(u32 val, size_t offset, size_t sz); void WriteGicdRegister(u32 val, size_t offset, size_t sz);
u32 ReadGicdRegister(size_t offset, size_t sz); u32 ReadGicdRegister(size_t offset, size_t sz);
void MaintenanceInterruptHandler();
void EnqueuePhysicalIrq(u32 id);
void Initialize();
}; };
} }