nold/Atmosphere
1
0
Fork 0
mirror of https://github.com/Atmosphere-NX/Atmosphere synced 2024-11-14 00:56:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

sm: remove apm:p compatibility hack

Browse source 
Homebrew which would hang when doing this were compiled with libnx < 3.0.0.

Homebrew which is compiled with < 3.0.0 cannot send messages to sm, because
of the incorrect serialization problem (which required homebrew recompile when
12.0.0 released).

Thus, there is no case where this makes a difference.
This commit is contained in:
Michael Scire 2021-10-08 15:25:52 -07:00
parent 960ba52a43
commit 14c8801259
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
stratosphere/sm/source/impl/sm_service_manager.cpp
View file

@ -554,14 +554,6 @@ namespace ams::sm::impl {
/* Validate service name. */ /* Validate service name. */
R_TRY(ValidateServiceName(service)); R_TRY(ValidateServiceName(service));
/* In 8.0.0, Nintendo removed the service apm:p -- however, all homebrew attempts to get */
/* a handle to this when calling appletInitialize(). Because hbl has access to all services, */
/* This would return true, and homebrew would *wait forever* trying to get a handle to a service */
/* that will never register. Thus, in the interest of not breaking every single piece of homebrew */
/* we will provide a little first class help. */
constexpr ServiceName ApmP = ServiceName::Encode("apm:p");
R_UNLESS((hos::GetVersion() < hos::Version_8_0_0) || (service != ApmP), sm::ResultNotAllowed());
/* Check that the process is registered and allowed to get the service. */ /* Check that the process is registered and allowed to get the service. */
if (!IsInitialProcess(process_id)) { if (!IsInitialProcess(process_id)) {
ProcessInfo *proc = GetProcessInfo(process_id); ProcessInfo *proc = GetProcessInfo(process_id);
@ -762,7 +754,6 @@ namespace ams::sm::impl {
service_info->mitm_port_h = os::InvalidNativeHandle; service_info->mitm_port_h = os::InvalidNativeHandle;
service_info->mitm_query_h = os::InvalidNativeHandle; service_info->mitm_query_h = os::InvalidNativeHandle;
service_info->mitm_process_id = os::InvalidProcessId; service_info->mitm_process_id = os::InvalidProcessId;
} }
return ResultSuccess(); return ResultSuccess();