nold/Atmosphere
1
0
Fork 0
mirror of https://github.com/Atmosphere-NX/Atmosphere synced 2024-12-22 12:21:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

fs: fix inverted optional-lock condition

Browse source
This commit is contained in:
Michael Scire 2022-03-26 15:28:40 -07:00
parent e5c3d264ec
commit 07cd682460
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libraries/libstratosphere/source/fssystem/fssystem_crypto_configuration.cpp
View file

@ -136,13 +136,13 @@ namespace ams::fssystem {
void ComputeCtr(void *dst, size_t dst_size, int key_slot_idx, const void *src, size_t src_size, const void *iv, size_t iv_size) { void ComputeCtr(void *dst, size_t dst_size, int key_slot_idx, const void *src, size_t src_size, const void *iv, size_t iv_size) {
if (dst == src) { if (dst == src) {
/* If the destination and source are the same, we'll use an intermediate buffer. */ /* If the destination and source are the same, we'll use an intermediate buffer. */
constexpr size_t MinimumSizeToSkipLocking = 256_KB; constexpr size_t MinimumSizeToRequireLocking = 256_KB;
constexpr size_t MinimumWorkBufferSize = 16_KB; constexpr size_t MinimumWorkBufferSize = 16_KB;
/* If the request isn't too large, acquire a lock to prevent too many small requests in flight simultaneously. */ /* If the request isn't too large, acquire a lock to prevent too many large requests in flight simultaneously. */
static constinit os::SdkMutex s_small_work_buffer_mutex; static constinit os::SdkMutex s_small_work_buffer_mutex;
util::optional<std::scoped_lock<os::SdkMutex>> lk = util::nullopt; util::optional<std::scoped_lock<os::SdkMutex>> lk = util::nullopt;
if (dst_size < MinimumSizeToSkipLocking) { if (dst_size >= MinimumSizeToRequireLocking) {
lk.emplace(s_small_work_buffer_mutex); lk.emplace(s_small_work_buffer_mutex);
} }